Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash when converting tags to Terraform format #294

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

shadycuz
Copy link
Member

@shadycuz shadycuz commented May 1, 2024

In some cases the tags might be a literal condition. This is a bandaid to try and handle that case but it is not a complete solution. Fixes #290

In some cases the tags might be a literal condition. This is a bandaid
to try and handle that case but it is not a complete solution.
@shadycuz shadycuz added bug Something isn't working patch labels May 1, 2024
@shadycuz shadycuz changed the title fix error when converting tags that are not list of maps fix crash when converting tags to Terraform format May 1, 2024
Copy link

codecov bot commented May 1, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 89.13%. Comparing base (e22cab6) to head (a5f76b0).
Report is 14 commits behind head on develop.

Files Patch % Lines
src/cf2tf/conversion/overrides.py 50.00% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #294      +/-   ##
===========================================
- Coverage    89.77%   89.13%   -0.65%     
===========================================
  Files           16       16              
  Lines         1135     1141       +6     
  Branches       184      183       -1     
===========================================
- Hits          1019     1017       -2     
- Misses          82       89       +7     
- Partials        34       35       +1     
Flag Coverage Δ
unit 89.13% <55.55%> (-0.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shadycuz shadycuz merged commit 5ff8d19 into develop May 1, 2024
9 of 11 checks passed
@shadycuz shadycuz deleted the fix_tag_conv branch May 1, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant